Skip to content

[docs][data grid] Audit and revise the Pro column docs #17844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jun 6, 2025

Conversation

mapache-salvaje
Copy link
Contributor

@mapache-salvaje mapache-salvaje commented May 14, 2025

Part of the ongoing auditing/editing project, prioritizing Pro and Premium features.

Pages audited: Column ordering, Column pinning

  • changes "Column ordering" to "Drag-and-drop column reordering"
  • adds more structure to the pages via informative headers
  • implements style guide and best practices

@mapache-salvaje mapache-salvaje added docs Improvements or additions to the documentation scope: data grid Changes or issues related to the data grid product plan: Pro Impact at least one Pro user type: enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be auto-cherry-picked to a version branch after merge—add a version label as target v7.x labels May 14, 2025
@mui-bot
Copy link

mui-bot commented May 14, 2025

Deploy preview: https://deploy-preview-17844--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Total Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%)
Files: 120 total (0 added, 0 removed, 0 changed)

Details of bundle changes

Generated by 🚫 dangerJS against 0e83b98


<p class="description">Drag and drop your columns to reorder them.</p>
<p class="description">The Data Grid Pro lets users drag and drop columns to reorder them.</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be more specific about "you" the developer vs "the users" they're developing for

@@ -1,36 +1,43 @@
---
title: Data Grid - Column ordering
title: Data Grid - Drag-and-drop column reordering
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name "Column ordering" doesn't really tell me what this page is about, which is the drag-and-drop reordering feature. I wouldn't necessarily think to look here for this information.

@mapache-salvaje mapache-salvaje force-pushed the column-ordering-pinning branch from df14ffb to 24f2d15 Compare May 19, 2025 13:38
@mapache-salvaje mapache-salvaje marked this pull request as ready for review May 21, 2025 00:12
@mapache-salvaje mapache-salvaje added the feature: Column pinning Related to the data grid Column pinning feature label May 21, 2025
Copy link
Contributor

@alelthomas alelthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look pretty solid to me! Would be good to get at least @michelengelen approval next.

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry for the late reply ... It got flooded over from other stuff! 🙇🏼

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 4, 2025
Copy link

github-actions bot commented Jun 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 4, 2025
Signed-off-by: mapache-salvaje <[email protected]>
@mapache-salvaje mapache-salvaje merged commit e23092e into mui:master Jun 6, 2025
22 checks passed
@mapache-salvaje mapache-salvaje deleted the column-ordering-pinning branch June 6, 2025 15:47
Copy link

github-actions bot commented Jun 6, 2025

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation feature: Column pinning Related to the data grid Column pinning feature needs cherry-pick The PR should be auto-cherry-picked to a version branch after merge—add a version label as target plan: Pro Impact at least one Pro user scope: data grid Changes or issues related to the data grid product type: enhancement This is not a bug, nor a new feature v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants