-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[docs][data grid] Audit and revise the Pro column docs #17844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][data grid] Audit and revise the Pro column docs #17844
Conversation
Deploy preview: https://deploy-preview-17844--material-ui-x.netlify.app/ Updated pages:
Bundle size reportTotal Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%) |
|
||
<p class="description">Drag and drop your columns to reorder them.</p> | ||
<p class="description">The Data Grid Pro lets users drag and drop columns to reorder them.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be more specific about "you" the developer vs "the users" they're developing for
@@ -1,36 +1,43 @@ | |||
--- | |||
title: Data Grid - Column ordering | |||
title: Data Grid - Drag-and-drop column reordering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name "Column ordering" doesn't really tell me what this page is about, which is the drag-and-drop reordering feature. I wouldn't necessarily think to look here for this information.
df14ffb
to
24f2d15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look pretty solid to me! Would be good to get at least @michelengelen approval next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry for the late reply ... It got flooded over from other stuff! 🙇🏼
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: mapache-salvaje <[email protected]>
Signed-off-by: mapache-salvaje <[email protected]>
Signed-off-by: mapache-salvaje <[email protected]>
Cherry-pick PRs will be created targeting branches: v7.x |
Signed-off-by: mapache-salvaje <[email protected]>
Part of the ongoing auditing/editing project, prioritizing Pro and Premium features.
Pages audited: Column ordering, Column pinning